Skip to content

chore(nx): enable dependency-aware project analysis - #8003

Draft
beaussan wants to merge 2 commits into
mainfrom
codex/nx-js-auto-dependency-updates
Draft

chore(nx): enable dependency-aware project analysis#8003
beaussan wants to merge 2 commits into
mainfrom
codex/nx-js-auto-dependency-updates

Conversation

@beaussan

@beaussan beaussan commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add @nx/js so Nx discovers source-level project dependencies
  • scope lockfile-only affected calculation to changed pnpm importers with projectsAffectedByDependencyUpdates: "auto"
  • exclude the test-fixture-only start-plugin-core -> react-start edge that otherwise creates a circular build task graph

Impact

  • Architecture: Nx project graph now includes source imports in addition to package metadata; the validated graph has 435 projects and 1,407 internal edges.
  • CI performance: lockfile changes no longer automatically mark all 435 projects affected; affected scope follows changed importers and their dependents.
  • Risk: source analysis broadens graph fan-out. The explicit negative dependency removes only a test-fixture import and keeps production package dependencies represented.
  • User-facing changes: None.

Testing

  • pnpm install --lockfile-only --ignore-scripts --frozen-lockfile
  • CI=1 NX_DAEMON=false pnpm nx graph --file=/tmp/router-nx-js-project-graph-resolved.json
  • CI=1 NX_DAEMON=false pnpm test:eslint --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm test:types --outputStyle=stream --skipRemoteCache
  • CI=1 NX_DAEMON=false pnpm test:unit --outputStyle=stream --skipRemoteCache

Router Generator was detected as flaky: the first unit run encountered stale empty local fixture directories; after removing those generated directories, the focused target and full unit suite passed.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 892fcaa1-d831-4dc6-92d4-160d42564e95

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 8d873e7

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 4m 31s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 26s View ↗

☁️ Nx Cloud last updated this comment at 2026-08-08 10:09:11 UTC

@socket-security

socket-security Bot commented Aug 8, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​nx/​js@​22.7.5771009399100

View full report

@socket-security

socket-security Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm @nx/workspace is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: pnpm-lock.yamlnpm/@nx/js@22.7.5npm/@nx/workspace@22.7.5

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@nx/workspace@22.7.5. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

This pull request does not affect bundle size in any measured scenario.

@pkg-pr-new

pkg-pr-new Bot commented Aug 8, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@8003

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8003

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8003

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@8003

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8003

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@8003

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@8003

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8003

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@8003

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@8003

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@8003

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@8003

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@8003

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@8003

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@8003

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@8003

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@8003

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@8003

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8003

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@8003

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8003

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@8003

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8003

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8003

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@8003

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@8003

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@8003

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@8003

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8003

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@8003

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@8003

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8003

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@8003

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@8003

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8003

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@8003

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8003

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8003

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@8003

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@8003

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@8003

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@8003

commit: 7630436

@codspeed-hq

codspeed-hq Bot commented Aug 8, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 13.37%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 9 regressed benchmarks
✅ 169 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory mem server error-paths redirect (vue) 294 KB 570.1 KB -48.44%
Memory mem client unique-location-churn (solid) 341.6 KB 659.2 KB -48.17%
Simulation ssr dehydrate rich types (solid) 87.3 ms 99 ms -11.76%
Simulation ssr dehydrate plain control (solid) 119.6 ms 129.3 ms -7.52%
Memory mem client unique-location-churn (vue) 984 KB 1,032.3 KB -4.68%
Memory mem server server-fn-churn (vue) 263.1 KB 274.8 KB -4.27%
Memory mem client navigation-churn (solid) 570.2 KB 593.7 KB -3.96%
Memory mem server error-paths unmatched (react) 263.6 KB 274.3 KB -3.9%
Simulation ssr request loop (solid) 158 ms 163.8 ms -3.51%
Memory mem server error-paths redirect (solid) 588.2 KB 532.5 KB +10.47%
Memory mem client preload-churn (vue) 776.2 KB 737 KB +5.33%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/nx-js-auto-dependency-updates (7630436) with main (c568caf)

Open in CodSpeed

@nx-cloud nx-cloud Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a flaky task in your failed CI:

🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.

Nx Cloud View detailed reasoning in Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant